fix(release): skip unsupported windows/arm build target - #37
Merged
Conversation
A local goreleaser snapshot build fails with "unsupported GOOS/GOARCH pair windows/arm" — Go has no 32-bit ARM Windows target, but the build matrix (goos includes windows, goarch includes arm) produced that combination. CI's goreleaser check only validates config syntax, so this would have surfaced only on the first real tagged release. Add windows/arm to the ignore list. Verified with a snapshot build: 13 platform zips + SHA256SUMS + manifest.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A local GoReleaser snapshot dry-run (RELEASING.md Phase 1, Step 4) failed:
The build matrix (
goosincludeswindows,goarchincludesarm) produceswindows/arm, which Go has no target for. CI'sgoreleaser checkonly validates config syntax, not builds — so this would have surfaced only on the first real tagged release, failing thereleaseworkflow after a tag push.Fix: add
windows/armto theignorelist (alongside the existingdarwin/386).Verified with
goreleaser release --snapshot --clean --skip=sign: clean build producing 13 platform zips (darwin amd64/arm64, freebsd 386/amd64/arm/arm64, linux 386/amd64/arm/arm64, windows 386/amd64/arm64) +SHA256SUMS+ the protocol-6manifest.json.